Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples - Updated with-windcss example for App Router #69365

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Examples - Updated with-windcss example for App Router #69365

merged 5 commits into from
Aug 27, 2024
+30 −28

Conversation

archanaagivale30
Copy link
Contributor

This PR updates the with-windcss example to use the App Router. Here are the changes that have been made:

  • Renamed the "pages" folder to "app" folder.
  • Updated the file index.tsx to page.tsx to align with App Router
  • Added the layout.tsx file as part of the App Router.
  • removed tag
  • updated package versions

cc @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Aug 27, 2024
@ijjk
Copy link
Member

ijjk commented Aug 27, 2024 •
edited by samcx

Allow CI Workflow Run

  • approve CI run for commit: bda512a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/windicss-webpack-plugin@1.8.0 environment, unsafe Transitive: filesystem +5 325 kB harlan_zw

🚮 Removed packages: npm/windicss-webpack-plugin@1.6.7), npm/windicss@3.5.1)

View full report↗︎

@samcx samcx self-requested a review August 27, 2024 14:09
samcx
samcx approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx enabled auto-merge (squash) August 27, 2024 14:09
@samcx samcx merged commit 1a52d9e into vercel:canary Aug 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@archanaagivale30 @ijjk @samcx