Chore/update with supa #69336
Draft
Chore/update with supa #69336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
saltcod
commented
Aug 26, 2024
| @@ -1,6 +0,0 @@ | |||
| import { clsx, type ClassValue } from "clsx"; | |||
There was a problem hiding this comment.
dupe, already in utils.ts
saltcod
commented
Aug 27, 2024
| @@ -0,0 +1,4 @@ | |||
| # Update these with your Supabase details from your project settings > API | |||
| # https://app.supabase.com/project/_/settings/api | |||
There was a problem hiding this comment.
this was deleted from Jonny's branch
saltcod
commented
Aug 27, 2024
| @@ -72,7 +73,9 @@ If you wish to just develop locally and not deploy to Vercel, [follow the steps | |||
|
|
|||
| Both `NEXT_PUBLIC_SUPABASE_URL` and `NEXT_PUBLIC_SUPABASE_ANON_KEY` can be found in [your Supabase project's API settings](https://app.supabase.com/project/_/settings/api) | |||
|
|
|||
| 5. You can now run the Next.js local development server: | |||
| 5. This template comes with the default shadcn/ui style initialized. If you instead want the `New York` style, delete `components.json` and [re-install shadcn/ui](https://ui.shadcn.com/docs/installation/next) | |||
There was a problem hiding this comment.
since we initialize shadcn for them
saltcod
commented
Aug 27, 2024
| @@ -12,7 +12,7 @@ export function FormMessage({ message }: { message: Message }) { | |||
| </div> | |||
| )} | |||
| {"error" in message && ( | |||
| <div className="text-destructive-foreground border-l-2 border-destructive-foreground px-4"> | |||
| <div className="text-red-500 border-l-2 border-destructive-foreground px-4"> | |||
There was a problem hiding this comment.
colour wasn't working in light mode, so went with red
There was a problem hiding this comment.
weird, i'll check what's wrong.
shouddn't use hard coded colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branched off @MildTomato's PR here:
#69308