Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Supabase | ui.shadcn, App Router Layouts #69308

Merged
merged 38 commits into from
Aug 28, 2024

Conversation

MildTomato
Copy link
Contributor

@MildTomato MildTomato commented Aug 26, 2024

  • Updated to use App Router layouts
  • Updated to use ui.shadcn
  • Updated Forms to return errors from actions
  • Bumped a few version numbers
  • added next-themes
  • added actions.ts
  • user JSON now shown on login

@ijjk ijjk added the examples Issue/PR related to examples label Aug 26, 2024
@ijjk
Copy link
Member

ijjk commented Aug 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: c0b02c2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Aug 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: 49e1e93

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

socket-security bot commented Aug 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/lucide-react@0.436.0 None 0 24.5 MB ericfennis
npm/next-themes@0.3.0 None 0 18.2 kB paco

View full report↗︎

@MildTomato MildTomato changed the title WIP Supabase | Chore/update with supabase Supabase | Chore/update with supabase Aug 26, 2024
@MildTomato MildTomato changed the title Supabase | Chore/update with supabase examples: Supabase | Chore/update with supabase Aug 26, 2024
@MildTomato MildTomato changed the title examples: Supabase | Chore/update with supabase examples: Supabase | ui.shadcn, App Router Layouts Aug 26, 2024
@MildTomato
Copy link
Contributor Author

Still sorting some issues with instructions

@@ -0,0 +1,36 @@
import * as React from "react";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All shadcn files are in components/ui but they should be in components folder according to the components.json. Change components.json (probably more correct) or move them back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadcn adds ui directory itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its just not well documented

Copy link
Contributor Author

@MildTomato MildTomato Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components.json is what placed them in the right directory I think, i used the CLI to add components

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@leerob leerob merged commit 00f70f2 into vercel:canary Aug 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants