Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: esm externals #69232

Draft
wants to merge 5 commits into
base: 14-2-1
Choose a base branch
from
Draft

backport: esm externals #69232

wants to merge 5 commits into from
+202 −225

Conversation

lubieowoce
Copy link
Member

@lubieowoce lubieowoce commented Aug 23, 2024 •
edited

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024 •
edited

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
/docs/app/building-your-application/optimizing/package-bundling#analyzing-javascript-bundles link /docs/02-app/01-building-your-application/06-optimizing/13-memory-usage.mdx

Thank you 🙏

@ijjk
Copy link
Member

ijjk commented Aug 23, 2024 •
edited

Failing test suites

Commit: 1e2d4f7

TURBOPACK=1 pnpm test-start test/e2e/app-dir/app-external/app-external.test.ts (turbopack)

  • app dir - external dependency > server actions > should prefer to resolve esm over cjs for bundling optout packages
Expand output

● app dir - external dependency › server actions › should prefer to resolve esm over cjs for bundling optout packages

TIMED OUT: /success/

undefined

Error: expect(received).toBe(expected) // Object.is equality

Expected: "dual-pkg-optout:mjs"
Received: "dual-pkg-optout:cjs"

  651 |
  652 |   if (hardError) {
> 653 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  654 |   }
  655 |   return false
  656 | }

  at check (lib/next-test-utils.ts:653:11)
  at Object.<anonymous> (e2e/app-dir/app-external/app-external.test.ts:292:9)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test-start test/e2e/esm-externals/esm-externals.test.ts (turbopack)

  • esm-externals > should return the correct SSR HTML for /server
  • esm-externals > should render the correct page for /server
  • esm-externals > should return the correct SSR HTML for /client
Expand output

● esm-externals › should return the correct SSR HTML for /server