-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: inform middleware usage along with metadata files #69136
docs: inform middleware usage along with metadata files #69136
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devjiwonchoi and the rest of your teammates on Graphite |
Graphite Automations"Notification" took an action on this PR • (08/21/24)1 teammate was notified to this PR based on Wyatt Johnson's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better have a test to cover the case configured middleware matcher with sitemap.xml
Thank you for the docs update @devjiwonchoi 🙏🏼 |
Merge activity
|
448d79b
to
e2439cb
Compare
What?
When the user sets
robots.ts
,sitemap.ts
, or other metadata files withmiddleware.ts
, it may end in unexpected behavior if the middleware matcher is not set to ignore the corresponding paths.Why?
The docs are missing the information for the users to "configure middleware matcher if you have one along with generating metadata files to prevent route interference".
How?
Updated the docs to add the matcher configuration as:
Added a "Good to Know" at the entry of metadata API to configure the middleware matcher if used.
Closes NDX-219