Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the example of custom-routes-proxying to utilize the App Router #68941

Merged
merged 8 commits into from
Aug 22, 2024
Merged

updated the example of custom-routes-proxying to utilize the App Router #68941

merged 8 commits into from
Aug 22, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

@Sam-Phillemon9493 Sam-Phillemon9493 commented Aug 15, 2024 •
edited

This PR updates the custom-routes-proxying example to use the App Router. Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Updated the routing for /, /about & /hello/[slug] files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.
  • Updated the Readme file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Aug 15, 2024
@ijjk
Copy link
Member

ijjk commented Aug 15, 2024 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: b7fb8bc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review August 15, 2024 15:06
@samcx samcx enabled auto-merge (squash) August 22, 2024 22:05
@samcx samcx self-requested a review August 22, 2024 22:05
samcx
samcx approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx merged commit 49ef978 into vercel:canary Aug 22, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob left review comments

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sam-Phillemon9493 @ijjk @leerob @samcx