-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next + Supabase quick start: fix error message #68892
base: canary
Are you sure you want to change the base?
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Just to say that @josueJURE and I worked on this together (my first pair-programming experience), and we are both new to contributing to the community. Any feedback or comments would be much appreciated. I have subscribed to the issue so will be notified of any developments. |
@@ -45,7 +45,11 @@ export default function Login({ | |||
}); | |||
|
|||
if (error) { | |||
return redirect("/login?message=Could not authenticate user"); | |||
const { code } = error | |||
if (code) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you please run Prettier in the repo for these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leerob apologies I understand @josueJURE has had two weeks of busy interviews and may not have been able to attend to this. I'll be in touch with him to see if there is anything I can help. I am not sure whether I can take over and submit the PR on my @3willows account.
Following up here, could you take a look at the Prettier (formatting) issue and address the merge conflicts please? |
What?
Fix issue marked as first good issue by Supabase maintainers, see discussion here.
Why?
Improved UX by removing confusion described in this blogpost.
How?