Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next + Supabase quick start: fix error message #68892

Open
wants to merge 4 commits into
base: canary
Choose a base branch
from

Conversation

josueJURE
Copy link

What?

Fix issue marked as first good issue by Supabase maintainers, see discussion here.

Why?

Improved UX by removing confusion described in this blogpost.

How?

  • More descriptive error message.
  • Where available, show the "email rate limit exceeded" error message to the user.

@ijjk ijjk added the examples Issue/PR related to examples label Aug 14, 2024
@ijjk
Copy link
Member

ijjk commented Aug 14, 2024

Allow CI Workflow Run

  • approve CI run for commit: bef15c5

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@3willows
Copy link

Just to say that @josueJURE and I worked on this together (my first pair-programming experience), and we are both new to contributing to the community.

Any feedback or comments would be much appreciated. I have subscribed to the issue so will be notified of any developments.

@@ -45,7 +45,11 @@ export default function Login({
});

if (error) {
return redirect("/login?message=Could not authenticate user");
const { code } = error
if (code) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please run Prettier in the repo for these changes?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leerob apologies I understand @josueJURE has had two weeks of busy interviews and may not have been able to attend to this. I'll be in touch with him to see if there is anything I can help. I am not sure whether I can take over and submit the PR on my @3willows account.

@leerob
Copy link
Member

leerob commented Aug 26, 2024

Following up here, could you take a look at the Prettier (formatting) issue and address the merge conflicts please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants