Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate with-react-hook-form example to App Router #68428

Open
wants to merge 6 commits into
base: canary
Choose a base branch
from

Conversation

Morteza-Porabdolahi
Copy link

What?

Just migrated with-react-hook-form example to use App router.

Why?

According to Next Js documentation, It's recommended for new projects to start using App router instead of pages router.

@ijjk ijjk added the examples Issue/PR related to examples label Aug 2, 2024
@ijjk
Copy link
Member

ijjk commented Aug 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0e601dc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob
Copy link
Member

leerob commented Aug 15, 2024

Looks like linting is failing, could you please run Prettier?

@Morteza-Porabdolahi
Copy link
Author

Morteza-Porabdolahi commented Aug 16, 2024

Looks like linting is failing, could you please run Prettier?

Hey Lee, seems like there are no problems with linting on my side.

nextjs

Running pnpm prettier-fix also does not change anything. And also something strange that's happening while executing pnpm lint-fix is that eslint command exists because of the heap memory.

heap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants