Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base-server.ts #64926

Open
wants to merge 1 commit into
base: 14-2-1
Choose a base branch
from
Open

Update base-server.ts #64926

wants to merge 1 commit into from

Conversation

Talentaa
Copy link

fixed Error handling upgrade request TypeError: Cannot read properties of undefined (reading 'bind')
issue url #55802

@Talentaa
Update base-server.ts
45ad0a1 
fixed Error handling upgrade request TypeError: Cannot read properties of undefined (reading 'bind')
@ijjk
Copy link
Member

ijjk commented Apr 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: 45ad0a1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

ijjk
ijjk requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you add a test case for this that fails without the change, this doesn't seem like a full fix if _res.setHeader is having issues here.

@ijjk
Copy link
Member

ijjk commented Apr 24, 2024 •
edited

Failing test suites

Commit: 43f24d0

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/rsc-basic/rsc-basic.test.ts (PPR)

  • app dir - rsc basics > should be able to navigate between rsc routes
Expand output

● app dir - rsc basics › should be able to navigate between rsc routes

request.allHeaders: Target page, context or browser has been closed

  145 |           page.on('request', (request) => {
  146 |             requestsCount++
> 147 |             return request.allHeaders().then((headers) => {
      |                            ^
  148 |               if (
  149 |                 headers['RSC'.toLowerCase()] === '1' &&
  150 |                 // Prefetches also include `RSC`

  at Page.allHeaders (e2e/app-dir/rsc-basic/rsc-basic.test.ts:147:28)

Read more about building and testing Next.js in contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk ijjk requested changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Talentaa @ijjk