Skip to content

Commit

Permalink
Fix async dynamic client modules in graph traversal (#69202)
Browse files Browse the repository at this point in the history
Fixes a small error where app-client modules loaded dynamically were not being reached by the module graph traversal. This, afaik at the moment, completes the graph traversal fixes and the algorithm now reaches all modules.
  • Loading branch information
LichuAcu committed Aug 28, 2024
1 parent 59183b9 commit 5b3365e
Showing 1 changed file with 11 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,19 @@ pub async fn children_modules_idents(
modules_idents.insert(ident_str, hash);
}
ReferencedModule::AsyncLoaderModule(async_loader_module) => {
let async_loader_ident = async_loader_module
let loader_ident = async_loader_module
.ident()
.with_modifier(Vc::cell("async loader".into()));
let ident_str = async_loader_ident.to_string().await?.clone_value();
let hash = hash_xxh3_hash64(&ident_str);
modules_idents.insert(ident_str, hash);
let loader_ident_str = loader_ident.to_string().await?.clone_value();
let loader_hash = hash_xxh3_hash64(&loader_ident_str);
modules_idents.insert(loader_ident_str, loader_hash);

let loaded_client_ident = async_loader_module
.ident()
.with_layer(Vc::cell("app-client".into()));
let loaded_client_ident_str = loaded_client_ident.to_string().await?.clone_value();
let loaded_client_hash = hash_xxh3_hash64(&loaded_client_ident_str);
modules_idents.insert(loaded_client_ident_str, loaded_client_hash);
}
}
}
Expand Down

0 comments on commit 5b3365e

Please sign in to comment.