Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Meilisearch example #53251

Merged
merged 37 commits into from
Aug 22, 2024
Merged

Add Meilisearch example #53251

merged 37 commits into from
Aug 22, 2024

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Jul 27, 2023

Hello Next.js maintainers 👋

What?

  • Adding an example folder for Meilisearch starter with Next.js

Why?

  • Ease the integration of Next.js developers using Meilisearch
  • Support the launch of the Meilisearch Vercel integration

How?

  • Adding a with-meilisearch folder in examples/

I hope this PR matches your expectations regarding new examples. Let me know if I need to update anything. 🙏

Thanks in advance.

@Strift Strift requested review from a team as code owners July 27, 2023 10:21
@ijjk ijjk added the examples Issue/PR related to examples label Jul 27, 2023
@Strift
Copy link
Contributor Author

Strift commented Jul 31, 2023

Hi,

I have updated the Deploy button to remove the integration ID from it.

I will make a follow-up PR to update it when the Meilisearch Vercel integration is officially released.

@Strift
Copy link
Contributor Author

Strift commented Sep 27, 2023

Hi @leerob, thank you for your review!

I have made some changes to the project to address your feedback:

  • Update README
  • Migrate TailwindCSS configuration file to Typescript

I hope it's good now :)

@ijjk
Copy link
Member

ijjk commented Sep 28, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: cdf6b31

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Sep 28, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: 9057356

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

leerob
leerob previously approved these changes Sep 28, 2023
View reviewed changes
@leerob
Copy link
Member

leerob commented Nov 17, 2023 

/root/actions-runner/_work/next.js/next.js/examples/with-meilisearch/env.d.ts
  1:11  warning  'NodeJS' is defined but never used      @typescript-eslint/no-unused-vars
  2:13  warning  'ProcessEnv' is defined but never used  @typescript-eslint/no-unused-vars

✖ 2 problems (0 errors, 2 warnings)

@Strift Strift requested a review from leerob November 22, 2023 16:48
@Strift
Copy link
Contributor Author

Strift commented Feb 26, 2024

Hello,

I updated the dependencies and merged the changes from the canary branch. There seem to be no missing checks.

How can I help to move this forward?

@leerob
Copy link
Member

leerob commented Aug 15, 2024

Could you run Prettier again please?

@socket-security Socket Security
Copy link

socket-security bot commented Aug 22, 2024 •
edited

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@meilisearch/instant-meilisearch@0.19.3 network +1 1.87 MB meili-bot
npm/@types/react-instantsearch@6.10.4 None +12 3.83 MB types

View full report↗︎

@Strift
Copy link
Contributor Author

Strift commented Aug 22, 2024

Hey, I ran prettier and updated all dependencies as agreed :)

@leerob leerob merged commit f94c603 into vercel:canary Aug 22, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Strift @ijjk @leerob