-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cms-umbraco
example
#52777
base: canary
Are you sure you want to change the base?
Add cms-umbraco
example
#52777
Conversation
Hi @ijjk, Is there anything I can do to ease the review of this PR? If it helps anything I can setup an Umbraco site with a publicly available API for testing. |
Hi Next.js peeps 👋 is anyone able to help us get this thing reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
I'm really sorry to be poking you out of the blue here, @balazsorban44, but this example PR has been waiting more than two months with apparently only automated responses. The Umbraco community is looking forward to playing around with this one. I can see you've been merging other examples as of late... maybe you could point me in the direction of whom to ask for help in getting this one merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Could we have it use the App Router + Draft Mode, similar to the updated cms-wordpress
example? 🙏
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Hi @leerob, I can't entirely figure out what it is you'd like me to update 🙈 the example does use draft mode, though. And it is essentially a copy of the I did spot a few missing TypeScript rewrites in the preview API handling, so I have fixed those now. And I also did a re-linting to keep the example up-to-date with the current style preferences. Please let me know if you need me to do further updates to this 👍 |
Hi Vercel/Next.js team (ping @leerob) |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Following up - do you want to address the lint errors so we can get this merged? |
Hi @leerob 👋 thanks for following up. I'll have a look at fixing the linter errors this week - hopefully one of the next few days. |
@leerob should be good to go now 👍 |
This PR adds a sample blog powered by Umbraco CMS.
Umbraco CMS v12 (released June 29) adds headless capabilities directly to the Umbraco core. This PR showcases how a blog can be built using Umbraco CMS as backing content source.
This example is not to be mistaken with the Umbraco Heartcore example. Umbraco Heartcore is a SaaS platform built on top of Umbraco CMS.
A demo of this example can be found at https://nextjs-umbraco-sample-blog.vercel.app/.
pnpm build && pnpm lint
, see https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md)