Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cms-umbraco example #52777

Open
wants to merge 35 commits into
base: canary
Choose a base branch
from
Open

Add cms-umbraco example #52777

wants to merge 35 commits into from

Conversation

kjac
Copy link

@kjac kjac commented Jul 17, 2023

This PR adds a sample blog powered by Umbraco CMS.

Umbraco CMS v12 (released June 29) adds headless capabilities directly to the Umbraco core. This PR showcases how a blog can be built using Umbraco CMS as backing content source.

This example is not to be mistaken with the Umbraco Heartcore example. Umbraco Heartcore is a SaaS platform built on top of Umbraco CMS.

A demo of this example can be found at https://nextjs-umbraco-sample-blog.vercel.app/.

@kjac kjac requested review from timneutkens, ijjk, shuding, styfle, huozhi and a team as code owners July 17, 2023 10:41
@ijjk ijjk added the examples Issue/PR related to examples label Jul 17, 2023
@kjac
Copy link
Author

kjac commented Aug 7, 2023

Hi @ijjk,

Is there anything I can do to ease the review of this PR? If it helps anything I can setup an Umbraco site with a publicly available API for testing.

@kjac
Copy link
Author

kjac commented Aug 23, 2023

Hi Next.js peeps 👋 is anyone able to help us get this thing reviewed?

@kjac kjac requested a review from ztanner as a code owner September 20, 2023 11:35
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@kjac
Copy link
Author

kjac commented Sep 27, 2023

I'm really sorry to be poking you out of the blue here, @balazsorban44, but this example PR has been waiting more than two months with apparently only automated responses.

The Umbraco community is looking forward to playing around with this one. I can see you've been merging other examples as of late... maybe you could point me in the direction of whom to ask for help in getting this one merged?

@kjac
Copy link
Author

kjac commented Dec 6, 2023

Um so... does anyone have any say in this?

Uh..?

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Could we have it use the App Router + Draft Mode, similar to the updated cms-wordpress example? 🙏

@ijjk
Copy link
Member

ijjk commented Dec 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: 798c238

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Dec 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: 798c238

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Dec 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: 351435f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@kjac
Copy link
Author

kjac commented Jan 23, 2024

Hi @leerob,

I can't entirely figure out what it is you'd like me to update 🙈 the example does use draft mode, though. And it is essentially a copy of the cms-wordpress example. Or, at least that was the intent 😄

I did spot a few missing TypeScript rewrites in the preview API handling, so I have fixed those now. And I also did a re-linting to keep the example up-to-date with the current style preferences.

Please let me know if you need me to do further updates to this 👍

@hjaltedaniel-umbraco
Copy link

Hi Vercel/Next.js team (ping @leerob)
What's the status on this one? Been talking to quite a few customers that could be customers of both front-end hosting from Vercel and CMS hosting from Umbraco, who'd be interested in seeing this PR merged in.

@leerob
Copy link
Member

leerob commented Aug 15, 2024

CleanShot 2024-08-15 at 11 59 07@2x

Copy link

socket-security bot commented Aug 20, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/autoprefixer@10.4.14 environment Transitive: filesystem +1 392 kB ai

View full report↗︎

@leerob
Copy link
Member

leerob commented Aug 26, 2024

Following up - do you want to address the lint errors so we can get this merged?

@kjac
Copy link
Author

kjac commented Aug 26, 2024

Hi @leerob 👋 thanks for following up. I'll have a look at fixing the linter errors this week - hopefully one of the next few days.

@kjac
Copy link
Author

kjac commented Aug 28, 2024

@leerob should be good to go now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants